User is able to select species specific search via Togglebutton #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Thank you @Steffengreiner for your work on the toggle button. I added some suggested refactorings to enhance usability of your component with an expressive API. We might re-use this component, so it think it is worth the effort. Have a look at it and write me what you think. I kindly ask you to provide some JDs for the class itself, what is its purpose or refer to a definition of a toggle button if available. I will not submit a review, because I dont want to block it during my absence :) Love the button! |
KochTobi
pushed a commit
that referenced
this pull request
Sep 3, 2024
* Provide CSS based implementation of toggle button * Suggest change for enhanced usability --------- Co-authored-by: Sven Fillinger <sven.fillinger@qbic.uni-tuebingen.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
The default checkbox for species specific search within the ontologylookupcomponent is replaced with a vaadin checkbox styled as a togglebutton as shown below
Screen.Recording.2024-08-29.at.17.29.26.mov