Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement style guide, showcase and dialog #919

Merged
merged 25 commits into from
Nov 28, 2024
Merged

Implement style guide, showcase and dialog #919

merged 25 commits into from
Nov 28, 2024

Conversation

sven1103
Copy link
Contributor

Implements first style guide requirements as concepts in CSS and Java classes.

Also comes with an own test-profile, that can be used to access a showcase page to see some of the style guide components in action.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sven1103 sven1103 changed the title Implement style guid, showcase and dialog Implement style guide, showcase and dialog Nov 19, 2024
@sven1103 sven1103 marked this pull request as ready for review November 25, 2024 13:18
@sven1103 sven1103 requested a review from a team as a code owner November 25, 2024 13:18
sven1103 and others added 13 commits November 26, 2024 09:23
@sven1103
Finalise dialog
f111f5d
@sven1103
Merge branch 'development' into feature/#914-functional-css-and-java-…
ed5d814 
…code-for-dialogs
@sven1103
Add JDs for the dialog
0f1a32f
@sven1103
Checkin progress
deb2474
@sven1103
Introduce confirmation dialog
dfa61a6
@sven1103
Rename SimpleDialog to AppDialog
3651383
@sven1103
Merge branch 'development' into feature/#914-functional-css-and-java-…
cd997b7 
…code-for-dialogs
@sven1103
Remove empty line
e16b872
@sven1103
Merge branch 'feature/#914-functional-css-and-java-code-for-dialogs' …
5d3897c 
…of github.com:qbicsoftware/data-manager-app into feature/#914-functional-css-and-java-code-for-dialogs
@sven1103
Merge branch 'development' into feature/#914-functional-css-and-java-…
a4a1553 
…code-for-dialogs
@sven1103
Adjust layout to UI feedback
c28004d
@sven1103
Fix typo in magic spell
a7e9af8
@sven1103
Adjust section header and description margins
73a49cf
@KochTobi KochTobi self-requested a review November 28, 2024 08:49
KochTobi
KochTobi requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@KochTobi KochTobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sven1103
Great changes! I see a lot of improvement coming.
However there are some questions that arose while looking at the code.

user-interface/src/main/resources/application-ui-test.properties Outdated Show resolved Hide resolved
user-interface/src/main/java/life/qbic/datamanager/views/demo/ComponentDemo.java Show resolved Hide resolved
user-interface/src/main/java/life/qbic/datamanager/views/general/dialog/DialogSection.java Show resolved Hide resolved
user-interface/src/main/java/life/qbic/datamanager/views/general/dialog/DialogSection.java Show resolved Hide resolved
user-interface/src/main/java/life/qbic/datamanager/views/general/dialog/AppDialog.java Show resolved Hide resolved
user-interface/frontend/themes/datamanager/components/all.css Show resolved Hide resolved
user-interface/frontend/themes/datamanager/components/all.css Show resolved Hide resolved
user-interface/frontend/themes/datamanager/components/all.css Show resolved Hide resolved
user-interface/frontend/themes/datamanager/components/all.css Show resolved Hide resolved
user-interface/frontend/themes/datamanager/components/all.css Outdated Show resolved Hide resolved
@sven1103 sven1103 requested a review from KochTobi November 28, 2024 13:36
@KochTobi KochTobi linked an issue Nov 28, 2024 that may be closed by this pull request
Functional CSS and Java code for dialogs #914
Closed
3 tasks
@sven1103 sven1103 merged commit 5e283d2 into development Nov 28, 2024
3 checks passed
@sven1103 sven1103 deleted the feature/#914-functional-css-and-java-code-for-dialogs branch November 28, 2024 14:14
@sven1103 sven1103 mentioned this pull request Nov 29, 2024
Closed
3 tasks
@sven1103 sven1103 mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KochTobi KochTobi KochTobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Functional CSS and Java code for dialogs
2 participants
@sven1103 @KochTobi