Add CLEAN_ONLY flag

[ghost]

When in an environment where there may be connectivity issues /tmp will be potentially filled by broken downloads. This happens as mktemp create new randomly named directories each time the script is run.

I know @qbit has issue #48 to remove some options but I felt this useful to add. I am not familiar with man page syntax so I did not add it there.

Thoughts? Perhaps it may be better to add cleaning of snap downloads in $DST or /tmp as the first step each time the script is run instead.

[qbit]

Let me think on this one. I haven't been happy with the mktemp change I made.. specifically because of the random dirs it makes. It also breaks adding -C to ftp's options for re-starting. I currently solved this by setting DST in my conf..

I also tend to run snap, then copy the verified dist files around to other machines on my network.. so I don't really want to auto-remove after the run..

[ghost]

Currently the way I implemented it the cleaning happens on demand, the auto clean was just an idea. What you said makes sense though as to why it should not happen automatically. I did not see a -C flag which is why I added it but the letter can be changed to anything really.

[qbit]

Yeah, the -C is specific to ftp.

So like I have this in my snap.conf:

FTP_OPTS:-C -V

Makes it so ftp resumes where it left off when a download fails.

[ghost]

Will that conflict? As far as I can tell with the -C that I added it exits after cleaning and never runs anything else. That should prevent it from conflicting with ftp. Perhaps when setting the variable it can jump to the function and ignore the other flags to ensure this behavior?

[qbit]

Looks good! Wanna go ahead and merge it? Then I will sign everything.

[ghost]

Merged, thanks for the review.

[qbit]

I missed it before, but there was a missing fi here. Please make sure you run the script after making changes, just to be sure it works!

[ghost]

Not sure how I missed that either. Will fix ASAP and get another PR in.

[qbit]

Not sure how I missed that either. Will fix ASAP and get another PR in.

No worries - I pushed a fix already (with slightly modified logic and comments explaining it :D)

[ghost]

Thanks. Will be extra diligent about testing going forward. Thanks for the explanation and updated logic.