Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download mac-os: add sequoia (most-recent) to list of supported os #234

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

download mac-os: add sequoia (most-recent) to list of supported os #234

wants to merge 5 commits into from

Conversation

clintonsteiner
Copy link

No description provided.

@Chocobo1 Chocobo1 mentioned this pull request Feb 21, 2025
Closed
@clintonsteiner
download mac-os: add sequoia (most-recent) to list of supported os
b134ac2
@clintonsteiner
Squashed commit of the following:
6a3189e 
commit 4b3f0d4
Merge: c5431db 19d0322
Author: csteiner <47841949+clintonsteiner@users.noreply.github.com>
Date:   Fri Feb 21 08:02:47 2025 -0600

    Merge branch 'master' into macOsRemoveUnsupportedOs

commit c5431db
Author: CJ Steiner <clintonsteiner@gmail.com>
Date:   Sat Jan 18 00:48:08 2025 -0600

    download: mac os remove Big Sur and Monterey as they are out of support
@clintonsteiner
Copy link
Author

Ready for review @Chocobo1

@Chocobo1
Copy link
Member

Ready for review @Chocobo1

It seems you forgot to add Sequoia to the list?

@clintonsteiner
Copy link
Author

Ready for review @Chocobo1

It seems you forgot to add Sequoia to the list?

Fixed - thanks for catching - got hung up in the merge conflicts with master

@Chocobo1
Copy link
Member

@xavier2k6
Feel free to chime in if you are interested in this PR.

@xavier2k6
Copy link
Member

xavier2k6 commented Feb 21, 2025 •
edited
Loading

I wouldn't merge this until after official 5.1 release which uses Qt 6.8.x

macOS 11, 12, 13, 14
https://doc.qt.io/qt-6.7/macos.html#supported-versions

macOS 12 or higher
https://doc.qt.io/qt-6.8/macos.html#supported-configurations

EDIT:

I would probably mention Monterey too & perhaps a rephrase to:
macOS 12 (Monterey) / macOS 13 (Ventura) / macOS 14 (Sonoma) / macOS 15 (Sequoia)

Unless of course we really are going to drop macOS 12 (Monterey) support & should really enforce it as per qbittorrent/qBittorrent#20459

@clintonsteiner
Copy link
Author

Changed to suggested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sledgehammer999 sledgehammer999 Awaiting requested review from sledgehammer999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clintonsteiner @Chocobo1 @xavier2k6