Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you uncheck files before starting a torrent, they still get downloaded #21440

Closed
steferrari opened this issue Sep 30, 2024 · 15 comments · Fixed by #21488
Closed

If you uncheck files before starting a torrent, they still get downloaded #21440

steferrari opened this issue Sep 30, 2024 · 15 comments · Fixed by #21488

Comments

@steferrari
Copy link

qBittorrent & operating system versions

qBittorrent: 5.0.0 x64
Operating system: Windows 10 Home (22H2)

What is the problem?

Immagine

I noticed that unchecked files on this window still ended up being downloaded.

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)


@HanabishiRecca
Copy link
Contributor

I guess what's going on here. You uncheck the text file, which has 0 size? If yes, that's intended.

@steferrari
Copy link
Author

I guess what's going on here. You uncheck the text file, which has 0 size? If yes, that's intended.

That was just an example, the same is happening with .nfo files.

This 100% wasn't happening with older qBittorrent versions, I definitely would have noticed plenty of unwanted files collecting in my main download folder.

@HanabishiRecca
Copy link
Contributor

Hmm, looks like this is the same issue as #21434.

@RandomEngineer
Copy link

RandomEngineer commented Oct 2, 2024

I also confirm it is creating files with 0kb
Even though the files are in the excluded file types list.
This wasn't the case pre v5, it would not create any files other than what was ticked for download.
I have confirmed when the torrent loads in the files are not ticked.

image image

QB v5.0.0 64bit
image

Win 11 Pro 64bit

@glassez
Copy link
Member

glassez commented Oct 2, 2024

This wasn't the case pre v5, it would not create any files other than what was ticked for download.

You're wrong. This has always been the case with 0 byte files.

@steferrari
Copy link
Author

This wasn't the case pre v5, it would not create any files other than what was ticked for download.

You're wrong. This has always been the case with 0 byte files.

I have to agree with him though.

As I previously said, those unchecked files never downloaded for me.

Now, with the new version, they download even if I uncheck them before starting the torrent.

Very easy for me to notice this because I mainly download movies so I only have video files in my main download folder.

Now, instead, I can find random files like the typical .nfo ones, etc.

@HanabishiRecca
Copy link
Contributor

HanabishiRecca commented Oct 2, 2024

This has always been the case with 0 byte files.

That's a different new issue unfortunately.
Obviously, the .jpg files on the screenshot are not originally 0-sized inside a torrent, but still created as 0-sized files while being unchecked.

#21434 has more details. I can't reproduce it on my Linux machine, but that could be a Windows-specific issue.

@glassez
Copy link
Member

glassez commented Oct 2, 2024

@steferrari
Or do you mean non 0 byte files?

@glassez
Copy link
Member

glassez commented Oct 2, 2024

Obviously, the .jpg files on the screenshot are not originally 0-sized inside a torrent, but still created as 0-sized files while being unchecked.

This is not visible either in the screenshots or from the description. Therefore, the first thing that comes to mind is originally 0 byte files.

@RandomEngineer
Copy link

Just to clarify.

The older versions 4.6.x did not download any files other files in the torrent, unless they were ticked.

I am 100% sure, as I also mainly dl movies and I only have the video file extensions allowed.

I also have confirmed the exclude file ext is working as it is only the video file checked to download.

In the example I have given, I can confirm the jpg file were not 0 bytes to start. This happens to all files they are not checked. QBT creates these empty files in the directory .

image

image

@HanabishiRecca
Copy link
Contributor

The older versions 4.6.x did not download any files other files in the torrent, unless they were ticked.

I am 100% sure, as I also mainly dl movies and I only have the video file extensions allowed.

Small files on piece boundaries always have been downloaded. Their content goes into hidden .parts files. That's just how torrent works.
You can go back to 4.6.x and confirm that they would have 100%.

And it is still the case for 5.0.0. The only difference is that for some people it creates dummy 0 byte files in places where unchecked files would have been.
We already established that. No more arguing required.

@RandomEngineer
Copy link

Ok, so no one is arguing, well certainly I am not, I'm attempting to explain how this issue is occurring because there seems to be confusion over which files I'm referring to.

I understand that various .parts files have always existed. There no question that is intended and happens. From the linked post it appears these 0bytes generated files would normally be moved into the .parts file?

But QT never generated any files for files that were not included for download. I have confirmed this by installing version 4.6.4 x64

So are you saying the difference is that for some people it creates dummy 0 byte files in places where unchecked files would have been. Is a bug or intended behaviour?

image

image

image

@HanabishiRecca
Copy link
Contributor

HanabishiRecca commented Oct 2, 2024

Is a bug or intended behaviour?

It's a bug of course. It should not happen. And it does not happen for me on Linux.
#21434 (comment)
#21434 (comment)

@MattWeiler
Copy link

This is 100% happening on Windows with V5.
On V4.6, unchecked files were never present in the final download folder upon torrent download completion.

It's not a huge deal, but annoying nonetheless.

@rl421403
Copy link

rl421403 commented Oct 3, 2024

I have also noticed the same thing happening from v5 on WIN10. It has never happened earlier. Now it has been creating 0 byte files which I had unchecked in the list before starting the torrent.

Of course not a huge deal but annoying.

glassez added a commit to glassez/qBittorrent that referenced this issue Oct 3, 2024
Trying to apply it to a nonexistent file is unacceptable, as it may unexpectedly create such a file.

Closes qbittorrent#21440.
brvphoenix pushed a commit to brvphoenix/qBittorrent that referenced this issue Oct 4, 2024
Trying to apply it to a nonexistent file is unacceptable, as it may unexpectedly create such a file.

Closes qbittorrent#21440.
@glassez glassez closed this as completed in 3fb5d77 Oct 5, 2024
glassez added a commit to glassez/qBittorrent that referenced this issue Oct 5, 2024
Trying to apply it to a nonexistent file is unacceptable, as it may unexpectedly create such a file.

PR qbittorrent#21488.
Closes qbittorrent#21440.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants