Revert using random port by default #12044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranciscoPombal
added
Network
Chocobo1
previously approved these changes
Feb 21, 2020
glassez
previously approved these changes
Feb 21, 2020
|
Someone once told me to not include periods in commit title. |
Yes, the period should be removed. |
FranciscoPombal
dismissed stale reviews from glassez and Chocobo1
via
0a85b6c
FranciscoPombal
force-pushed
the
fix-port
branch
from
06379dd to
0a85b6c
Compare
|
@Chocobo1 fixed commit message. |
glassez
changed the title
glassez
previously approved these changes
Feb 21, 2020
Revert change introduced in qbittorrent#11637 and also revert the associated follow-up qbittorrent#12000. Reason: arvidn/libtorrent#4335
FranciscoPombal
force-pushed
the
fix-port
branch
from
0a85b6c to
dc6a56a
Compare
|
Sorry had to force push to fix the commit author |
glassez
approved these changes
Feb 21, 2020
Chocobo1
approved these changes
Feb 21, 2020
|
@FranciscoPombal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert change introduced in #11637 and also revert the associated follow-up #12000.
Reason: arvidn/libtorrent#4335
Associated discussion: #11935 (after the initial closing of the issue).