Add support for exporting .torrent from WebUI #16968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
previously approved these changes
May 2, 2022
|
qBittorrent/src/webui/webapplication.h Line 51 in 56667e7 Almost forgot, this should be bumped to |
glassez
reviewed
May 2, 2022
| element.setAttribute("href", url); | ||
| element.setAttribute("download", name + ".torrent"); | ||
| document.body.appendChild(element); | ||
| element.click(); |
There was a problem hiding this comment.
Is there really no direct way to do this without creating some element behind the scenes and emulating the impact on it?
There was a problem hiding this comment.
I initially looked into sending the Content-Disposition header, which indicates to the browser that the response should be downloaded, but it doesn't appear that there's plumbing yet to allow setting arbitrary headers from API routes.
Piccirello
force-pushed
the
tom/webui-export-torrent
branch
from
ed6c958
to
0c65f6f
Compare
glassez
approved these changes
May 2, 2022
Chocobo1
approved these changes
May 3, 2022
|
@Piccirello |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new "Export .torrent" (#16886) functionality to the WebAPI/WebUI. Props to @Chocobo1 for making this as easy as possible. This has been tested in Firefox, Safari, and Chrome.