Add WebAPI/WebUI for managing cookies #21340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piccirello
added
WebUI
Piccirello
force-pushed
the
cookie-manager
branch
2 times, most recently
from
6980297 to
e87911f
Compare
Piccirello
force-pushed
the
cookie-manager
branch
2 times, most recently
from
99991f5 to
ced240c
Compare
Piccirello
commented
Sep 15, 2024
| @@ -787,7 +785,6 @@ void TorrentsController::pieceStatesAction() | |||
| void TorrentsController::addAction() | |||
| { | |||
| const QString urls = params()[u"urls"_s]; | |||
| const QString cookie = params()[u"cookie"_s]; | |||
There was a problem hiding this comment.
Do we have a WebAPI bump yet in 5.1? It'd be nice to get this in 5.0 if possible but otherwise can bump the WebAPI in 5.1 too.
Chocobo1
reviewed
Sep 20, 2024
Chocobo1
reviewed
Sep 20, 2024
Piccirello
force-pushed
the
cookie-manager
branch
from
ced240c to
25ff213
Compare
Piccirello
force-pushed
the
cookie-manager
branch
2 times, most recently
from
fcabdc5 to
67a7d3c
Compare
Chocobo1
reviewed
Sep 22, 2024
Piccirello
force-pushed
the
cookie-manager
branch
from
67a7d3c to
d99cda0
Compare
Piccirello
force-pushed
the
cookie-manager
branch
from
d99cda0 to
1b21aa7
Compare
Signed-off-by: Thomas Piccirello <thomas@piccirello.com>
Signed-off-by: Thomas Piccirello <thomas@piccirello.com>
The cookie manager should now be used. Signed-off-by: Thomas Piccirello <thomas@piccirello.com>
Piccirello
force-pushed
the
cookie-manager
branch
from
1b21aa7 to
c352f89
Compare
Chocobo1
approved these changes
Sep 28, 2024
thalieht
approved these changes
Sep 28, 2024
|
@Piccirello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21125