Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change combobox index after selection #21599

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Chocobo1
Copy link
Member

@Chocobo1 Chocobo1 commented Oct 12, 2024

Also keep the list sorted.

Before:
before
After:
after

@Chocobo1 Chocobo1 added the GUI GUI-related issues/changes label Oct 12, 2024
@Chocobo1 Chocobo1 added this to the 5.0.1 milestone Oct 12, 2024
@Chocobo1 Chocobo1 requested a review from a team October 12, 2024 22:54
Also keep the list sorted.
Fix up 2d185dc.
@glassez
Copy link
Member

glassez commented Oct 13, 2024

Also keep the list sorted.

Personally, I don't care about sorting in such a short list.
IMO, the inconsistent appearance of the elements is much worse. I'd rather fix it so that they display like this (if sorted):

  • Fusion
  • Windows
  • Windows 11
  • Windows Vista

...or maybe w/o spaces:

  • Fusion
  • Windows
  • Windows11
  • WindowsVista

@glassez
Copy link
Member

glassez commented Oct 13, 2024

Fix up 2d185dc.

Note that initial behavior was implemented that way intentionally. If you dislike it and people agree with you, let's change it. But please don't call initial one a "bug" that is "fixed" by this PR.

@Chocobo1 Chocobo1 merged commit fb40275 into qbittorrent:master Oct 14, 2024
14 checks passed
@Chocobo1 Chocobo1 deleted the style_sort branch October 14, 2024 06:39
@Chocobo1
Copy link
Member Author

Merging this early to unblock other PRs.

Note that initial behavior was implemented that way intentionally. If you dislike it and people agree with you, let's change it. But please don't call initial one a "bug" that is "fixed" by this PR.

From user perspective, it is hard to not call it a bug. Because no other combo box would swap indexes.
Anyway, I removed the "fix up" part.

@glassez
Copy link
Member

glassez commented Oct 14, 2024

From user perspective, it is hard to not call it a bug. Because no other combo box would swap indexes.

It's subjective. As a user, I probably wouldn't pay attention to this (it doesn't change the index every time you open the list, but only if you reopen the Preferences dialog, right?). For example, I am more annoyed by the inconsistent format of style names.

@Chocobo1
Copy link
Member Author

Chocobo1 commented Oct 14, 2024

It's subjective. As a user, I probably wouldn't pay attention to this (it doesn't change the index every time you open the list, but only if you reopen the Preferences dialog, right?).

I wouldn't be so liberal to call it subjective. A few design guides recommended to sort them:
https://learn.microsoft.com/en-us/windows/apps/design/controls/combo-box#recommendations
https://experience.sap.com/fiori-design-web/combo-box/#sorting

@glassez
Copy link
Member

glassez commented Oct 14, 2024

A few design guides recommended to sort them:

I'm not arguing with that. I'm just talking about user perception.

@stalkerok

This comment was marked as resolved.

glassez pushed a commit to glassez/qBittorrent that referenced this pull request Oct 21, 2024
@glassez

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants