-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't change combobox index after selection #21599
Conversation
Also keep the list sorted. Fix up 2d185dc.
Personally, I don't care about sorting in such a short list.
...or maybe w/o spaces:
|
Note that initial behavior was implemented that way intentionally. If you dislike it and people agree with you, let's change it. But please don't call initial one a "bug" that is "fixed" by this PR. |
Merging this early to unblock other PRs.
From user perspective, it is hard to not call it a bug. Because no other combo box would swap indexes. |
It's subjective. As a user, I probably wouldn't pay attention to this (it doesn't change the index every time you open the list, but only if you reopen the Preferences dialog, right?). For example, I am more annoyed by the inconsistent format of style names. |
I wouldn't be so liberal to call it subjective. A few design guides recommended to sort them: |
I'm not arguing with that. I'm just talking about user perception. |
This comment was marked as resolved.
This comment was marked as resolved.
Also keep the list sorted. PR qbittorrent#21599.
Also keep the list sorted.
Before:
![before](https://private-user-images.githubusercontent.com/9395168/376015163-fb754718-bb82-4883-9150-16bedc955abd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NTA4OTIsIm5iZiI6MTczOTQ1MDU5MiwicGF0aCI6Ii85Mzk1MTY4LzM3NjAxNTE2My1mYjc1NDcxOC1iYjgyLTQ4ODMtOTE1MC0xNmJlZGM5NTVhYmQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMTI0MzEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDg5OGQ4NWI1NTEwZTU5YWZjYmMyYWNhODdiMjk1NDc1MmQ5MzEzNDBjOWY5ZDg5ZmI2MzQ0NzFkYTJmZTUzNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.qWu_bPw9YjdazY75TPQP7W7-BCfjWlFw3Lx75zMHoTc)
![after](https://private-user-images.githubusercontent.com/9395168/376015162-d9e94ba4-40d3-421e-b3ad-2e06eee27c74.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NTA4OTIsIm5iZiI6MTczOTQ1MDU5MiwicGF0aCI6Ii85Mzk1MTY4LzM3NjAxNTE2Mi1kOWU5NGJhNC00MGQzLTQyMWUtYjNhZC0yZTA2ZWVlMjdjNzQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTNUMTI0MzEyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWJhM2FiMDk3MDgzOGIwMDhmODllMTM3ZmMwMmJmZDg3NDBmMmZlOTdhYWVmNGQ2NTk5YTI4NTJmZDY0NzE4OCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.76GF1nwwO6yfEf_B2b0bLYCPwx4Ax9eOcojB2EAbfvo)
After: