♿️ Improve calendar header accessibility by adding screen reader text for week numbers #56
+96
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een reader text for week numbers Closes Hacker0x01#3797
…& sr-only for the calendar header accessibility tests Closes Hacker0x01#3797
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Hacker0x01#3797
Description
As mentioned in the linked issue, the screen readers is currently reading the week names header using the text we set instead of the aria-label.
Changes
I added
aria-hidden="true"for all the week number headers and moved thearia-labelto the separatesr-onlyspan and addedcolheaderrole.Contribution checklist