Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XML builder #17

Merged
merged 9 commits into from
Jul 14, 2018
Merged

Implement XML builder #17

merged 9 commits into from
Jul 14, 2018

Conversation

qcam
Copy link
Owner

@qcam qcam commented May 1, 2018

Roadmap:

@stevedomin
Copy link
Contributor

Hi @qcam, any help needed to push this PR over the line?

@qcam
Copy link
Owner Author

qcam commented Jun 11, 2018

hey @stevedomin, helps are always welcome! This is a draft to experiment around how XML encoding interface would look like.

I've updated the roadmap for this PR (I might miss something or perhaps it could be split into smaller parts). Are you interested in working on any item on the list?

@qcam qcam force-pushed the cam/builder branch 3 times, most recently from 8ef9f19 to f05d61d Compare July 8, 2018 15:00
@qcam
Copy link
Owner Author

qcam commented Jul 8, 2018

First draft implemented. Benchmarking result was quite promising.

In comparison to xml_builder, the benchmark result on my local computer tells that Saxy encoder was about 9-10 times faster.

Operating System: macOS
CPU Information: Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz
Number of Available Cores: 4
Available memory: 16 GB
Elixir 1.6.5
Erlang 20.3.4
Benchmark suite executing with the following configuration:
warmup: 2 s
time: 5 s
parallel: 1
inputs: none specified
Estimated total run time: 14 s


Benchmarking saxy...
Benchmarking xml_builder...

Name                  ips        average  deviation         median         99th %
saxy             489.38 K        2.04 μs  ±2443.12%           2 μs           7 μs
xml_builder       47.29 K       21.15 μs   ±101.08%          21 μs          49 μs

Comparison:
saxy             489.38 K
xml_builder       47.29 K - 10.35x slower

@qcam qcam force-pushed the cam/builder branch 5 times, most recently from 93c1ac0 to a43bf8e Compare July 13, 2018 21:28
@qcam qcam merged commit 7266632 into master Jul 14, 2018
@qcam qcam deleted the cam/builder branch July 14, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants