use GitHub releases tarballs #108
Conversation
Skip existing remote branches
the default one is ok
mostly blacklist and whitelist for tags
ericLemanissier
force-pushed
the
github-releases
branch
2 times, most recently
from
e87452d to
484f10e
Compare
| @@ -117,15 +117,15 @@ jobs: | |||
| --no-link-pr \ | |||
| --github-token "$GITHUB_TOKEN" \ | |||
| ./status/v1-update.json \ | |||
| https://github.com/qchateau/conan-center-bot/issues/4 | |||
| https://github.com/${{ github.repository }}/issues/4 | |||
There was a problem hiding this comment.
Shouldn't you put the issue number in a CI env var ?
There was a problem hiding this comment.
Re-opening this thread as you're working in your fork - it will probably fail if the number is not configurable, right ?
Same line 90
There was a problem hiding this comment.
Ok, I'll put these issues numbers in a repo variable
ericLemanissier
force-pushed
the
github-releases
branch
from
d9ed54f to
acb4d41
Compare
it allows the use of aiohttp
ericLemanissier
force-pushed
the
github-releases
branch
from
acb4d41 to
58c26e5
Compare
ericLemanissier
force-pushed
the
github-releases
branch
from
15f7752 to
9f26a8c
Compare
|
I wonder why the CI doesn't run on this PR |
dev branches now use dev/ccb- prefix
ericLemanissier
force-pushed
the
github-releases
branch
3 times, most recently
from
dadcadd to
545406e
Compare
ericLemanissier
force-pushed
the
github-releases
branch
from
545406e to
2d9918c
Compare
with dev/ prefix for all branches
|
ok, I'm finally starting to get some results on my fork : https://ericlemanissier.github.io/conan-center-bot/ |
| @@ -117,15 +117,15 @@ jobs: | |||
| --no-link-pr \ | |||
| --github-token "$GITHUB_TOKEN" \ | |||
| ./status/v1-update.json \ | |||
| https://github.com/qchateau/conan-center-bot/issues/4 | |||
| https://github.com/${{ github.repository }}/issues/4 | |||
There was a problem hiding this comment.
Re-opening this thread as you're working in your fork - it will probably fail if the number is not configurable, right ?
Same line 90
| github_token = get_github_token() | ||
| headers = {"Accept": "application/vnd.github.v3+json"} | ||
| if github_token: | ||
| headers["Authorization"] = f"token {github_token}" |
There was a problem hiding this comment.
I think the CI now fails due to the rate limit of the token (or am I misinterpreting the logs ?)
I'm especially worried as the number of projects can only grow
There was a problem hiding this comment.
Yes, but it is because I always push 3 branches at the same time: master, dev, and the one of this PR. With each branch triggering 2 workflows, plus the PR's workflow, it makes a lot more requests than actually needed. The cron workflow always passes on my fork.
There was a problem hiding this comment.
Or maybe they are actually not using the token?
There was a problem hiding this comment.
Mmmm, actually the cron tab also has a problem: https://github.com/ericLemanissier/conan-center-bot/actions/runs/5021405590/jobs/9003755278#step:10:439
I'll see if we can use https://docs.github.com/en/rest/overview/resources-in-the-rest-api?apiVersion=2022-11-28#conditional-requests
ericLemanissier
force-pushed
the
github-releases
branch
7 times, most recently
from
54932de to
78dc856
Compare
ericLemanissier
force-pushed
the
github-releases
branch
from
78dc856 to
d0da888
Compare
fixes #106
This is based on top of #107 to ease my tests, but the change in
ccb/upstream_project.pyis totally independant from github workfows modifications.Contrary to other
Upstreamsub-classes, I had to do the request inGithubReleaseProjectconstructor (as opposed to theversions(self)property), because we have to know if there are some actual releases during construction, in order to try otherUpstreamtypes if there are no actual releases. This also implies that if the token becomes rate limited, the exception is caught, and otherUpstreamtypes are tried.Also, releases tarball download URL cannot be derived from version alone, so I cached the download url as member of the Version object. I could not cache it in the
GithubReleaseProjectinstance because several instances of the detectedUpstreamare created for each recipe during a single workflow.Examples of branches created by this modification: