Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newer npm packages break build #979

Closed
JDziurlaj opened this issue Jan 23, 2020 · 0 comments
Closed

Newer npm packages break build #979

JDziurlaj opened this issue Jan 23, 2020 · 0 comments
Labels
est:Minor Minor effort to implement est:Score=2 Score for estimate of effort required (scale of 1 upwards) fn:Platform-Integration problem:Bug A bug severity:Serious support This issue is a candidate to complete under the support agreement
Milestone
Bug fix pre-Suppo...

Comments

@JDziurlaj
Copy link

Current Behaviour (for problems)

The packages in the package.json use caret versioning, and some newer packages break the build. Specificially, css files are missing when they are expected. The following packages are affected

  • components-font-awesome
  • vue-directive-tooltip

Steps to Reproduce

run yarn build

Your Environment

  • Data Curator version: 1.1.0
  • Operating System and version: Windows 10
@ghost ghost added est:Score=2 Score for estimate of effort required (scale of 1 upwards) severity:Serious est:Minor Minor effort to implement fn:Platform-Integration problem:Bug A bug support This issue is a candidate to complete under the support agreement labels Apr 22, 2020
@ghost ghost added this to the Support release 2 milestone May 9, 2020
@ghost ghost closed this as completed in 1a466c0 May 11, 2020
ghost pushed a commit that referenced this issue Apr 21, 2021
Fixes: #979: Fix dependencies so upgrade does not trigger libraries w…
55757d8 
…hich require node version > 8 lts. Update use of font-awesome and vue-directive-tooltip with upgrade. Upgrade to babel 7 due to dependencies required in upgrade. Update configuration to support babel7 and deprecation of kitchen-sink env support. Move to Terser webpack and update config for faster packing (no more idling at >90%).
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
est:Minor Minor effort to implement est:Score=2 Score for estimate of effort required (scale of 1 upwards) fn:Platform-Integration problem:Bug A bug severity:Serious support This issue is a candidate to complete under the support agreement
Projects
None yet
Milestone
Bug fix pre-Support release 2
Development

No branches or pull requests
1 participant
@JDziurlaj