Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up TravisCI #13

Open
3 tasks
slifty opened this issue Apr 18, 2020 · 3 comments
Open
3 tasks

Set up TravisCI #13

slifty opened this issue Apr 18, 2020 · 3 comments
Assignees

Comments

@slifty
Copy link
Collaborator

slifty commented Apr 18, 2020

Task

Description
I will feel much more comfortable if we use TravisCI compile builds and run tests on PRs. This is particularly valuable because we don't have full code reviews on the project at this stage.

CI should:

  • run the linter
  • run the tests
  • build the project

Relevant resources / research

Related Issues
This is part of issue #4

@slifty slifty self-assigned this Apr 18, 2020
slifty added a commit that referenced this issue Apr 18, 2020
[TravisCI](travis-ci.org/) is a handy tool for continuous integration.
This sets up Travis to run the linter.

Issue #13 Set up TravisCI
@slifty slifty mentioned this issue Apr 18, 2020
4 tasks
@slifty
Copy link
Collaborator Author

slifty commented Apr 18, 2020

@kfogel Would you be willing to add TravisCI to this project? The first three steps of this guide will do the trick.

I should note, Travis is not FOSS but it is "Free" for open source projects. Using Travis instead of a FOSS alternative like Jenkins is a matter of convenience / fitting our budget right now. We are NOT locked into travis by using it now / it won't make it harder to use Jenkins later, and it does not affect the ability to develop.

@kfogel
Copy link
Member

kfogel commented Apr 27, 2020

Thanks for asking, @slifty. Travis is okay for now, since no developer will have to run it on their own machine, but of course it's not ideal. Could you please make a note of it in an issue as a proprietary semi-dependency that we'd like to get rid of soon? (And if I found someone to make the equivalent setup w/ Jenkins, presumably having them do the switchover wouldn't impose any time costs on you, right?)

@slifty
Copy link
Collaborator Author

slifty commented May 24, 2020

Excellent thank you -- FWIW I do see travis as similar to github in that the project doesn't need it to function or continue, it is just providing utility for now that could be replaced later with a FOSS solution.

And correct, no time cost on my end to switch later! Using travis now should be a matter of minutes to set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants