Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated name info assets #149

Merged
merged 6 commits into from
Aug 9, 2023
Merged

updated name info assets #149

merged 6 commits into from
Aug 9, 2023

Conversation

firojalam
Copy link
Contributor

No description provided.

@firojalam firojalam requested a review from fdalvi July 10, 2023 14:05
@fdalvi fdalvi mentioned this pull request Jul 24, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cases like:

{
  "input": "جورج بوش الابن",
  "label": "us",
  "model_output": "country: US",
  "filtered_output": null
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gpt4 fewshot asset also has similar outputs, but handles it, perhaps we just need to use the same postprocessing fn?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cases that we can handle easily I think:

{
  "input": "جورج بوش الابن",
  "label": "us",
  "model_output": "name: جورج بوش الأب country: united states of america</s>",
  "filtered_output": "جورج بوش الأب country: united states of america"
}
{
  "input": "جورج ووكر بوش",
  "label": "us",
  "model_output": "country_code: US</s>",
  "filtered_output": null
}
{
  "input": "George W. Bush",
  "label": "us",
  "model_output": "name: George W. Bush country:us</s>",
  "filtered_output": "george w. bush country:us"
}
{
  "input": "أوغستو بينوشيه",
  "label": "cl",
  "model_output": "name: أوغستو بينوشيه</s>",
  "filtered_output": "أوغستو بينوشيه"
}
{
  "input": "Augusto Pinochet",
  "label": "cl",
  "model_output": "country:CL</s>",
  "filtered_output": null
}

Also should we explicitly set to None if none of the labels are found? (e.g. when it outputs the original name back - sample 4 above)

@fdalvi fdalvi merged commit 6808392 into main Aug 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants