Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VLLM/FastChat updates #321

Merged
merged 4 commits into from
Jul 21, 2024
Merged

VLLM/FastChat updates #321

merged 4 commits into from
Jul 21, 2024

Conversation

fdalvi
Copy link
Collaborator

@fdalvi fdalvi commented Jul 11, 2024

No description provided.

@fdalvi fdalvi requested a review from firojalam July 11, 2024 06:30
@fdalvi fdalvi mentioned this pull request Jul 11, 2024
Merged
@fdalvi
Copy link
Collaborator Author

fdalvi commented Jul 11, 2024

Just leaving some thoughts here:

  • We should avoid model specific instantiations (Fanar, Jais etc)
  • We can roll user_session_id etc into optional parameters
  • If VLLM supports OpenAI out of the box, we can perhaps subclass from it like FastChatModel

@fdalvi fdalvi changed the title VLLM updates from Firoj VLLM/FastChat updates Jul 21, 2024
@firojalam firojalam merged commit dcb62b4 into main Jul 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@firojalam firojalam firojalam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fdalvi @firojalam