Feat/anthropic #326
Merged
Feat/anthropic #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdalvi
reviewed
Jul 30, 2024
There was a problem hiding this comment.
@firojalam Can you please update the docstring under def prompt(self, processed_input): to indicate what the required format is (and also maybe talk about multimodal?).
Right now, there are only two ways a user knows what their asset should return, either this doc string or a failing test. The test you have already done, but its nice to have this docstring reflect the correct format as well. Feel free to take a look at the other model docstrings as well.
|
Hi @fdalvi ,
|
fdalvi
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Fahim, please check if they test implementation is fine. Note anthropic models also support multimodality.