-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(control server authentication): add basic http auth #2423
Conversation
Please see and reply to #2238 (comment) 🙏 |
Can you point your PR towards the branch |
I've updated to use the auth middleware. |
6e2d9f4
to
7c177f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated to use the auth middleware
Awesome 💯 ❤️
FYI I rebased your branch + pushed a small commit to simplify code a bit
Sorry for the delay.
Please, no pressure at all 😸
b60f864
to
11f67e8
Compare
a0d825a
to
0d1fc2e
Compare
Partly fixes #2238
@qdm12 , please provide feedback.
Do we need a default username and password.
I have added basic auth only for the /settings route so that breakage with existing users are minimal.
Edit:
Original PR is updated to use the new auth middleware. Above points are no longer valid.
See #2238 , #2434