Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(control server authentication): add basic http auth #2423

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

joejose97
Copy link
Contributor

@joejose97 joejose97 commented Aug 18, 2024

  • Add basic http auth to vpn/settings & openvpn/settings routes.
  • Get username and password from environment variables.
  • Sets a default username and password.

Partly fixes #2238

@qdm12 , please provide feedback.
Do we need a default username and password.
I have added basic auth only for the /settings route so that breakage with existing users are minimal.

Edit:
Original PR is updated to use the new auth middleware. Above points are no longer valid.
See #2238 , #2434

@qdm12
Copy link
Owner

qdm12 commented Aug 19, 2024

Please see and reply to #2238 (comment) 🙏
My apologies for not doing this earlier, as @ezekieldas pointed out, this turns out to be rather urgent to fix/do something about it (changed the priority of the issue to urgent)!

@qdm12 qdm12 mentioned this pull request Aug 24, 2024
2 tasks
@qdm12
Copy link
Owner

qdm12 commented Aug 24, 2024

Can you point your PR towards the branch auth-middleware-2238 and inspire from #2437 to implement basic auth with the new 'auth code infrastructure' in place? 🙏 Thanks!

@qdm12 qdm12 marked this pull request as draft August 24, 2024 19:49
@joejose97 joejose97 marked this pull request as ready for review September 3, 2024 19:00
@joejose97
Copy link
Contributor Author

I've updated to use the auth middleware.
Sorry for the delay.

@joejose97 joejose97 changed the base branch from master to auth-middleware-2238 September 3, 2024 19:02
@joejose97 joejose97 changed the title feat(control server authentication): basic http auth for /settings ro… feat(control server authentication): add basic http auth Sep 3, 2024
@qdm12 qdm12 force-pushed the auth-middleware-2238 branch from 6e2d9f4 to 7c177f1 Compare September 4, 2024 19:59
Copy link
Owner

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated to use the auth middleware

Awesome 💯 ❤️
FYI I rebased your branch + pushed a small commit to simplify code a bit

Sorry for the delay.

Please, no pressure at all 😸

@qdm12 qdm12 force-pushed the auth-middleware-2238 branch 2 times, most recently from b60f864 to 11f67e8 Compare September 11, 2024 06:42
@qdm12 qdm12 force-pushed the master branch 2 times, most recently from a0d825a to 0d1fc2e Compare September 11, 2024 06:51
@qdm12 qdm12 merged commit 3191b3c into qdm12:auth-middleware-2238 Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: control server authentication
2 participants