Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos and misc fixes #53

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: typos and misc fixes #53

merged 1 commit into from
Sep 9, 2024

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented Sep 5, 2024

As the title goes.
Merging since trivial.

@Anush008 Anush008 requested a review from Robert-Stam September 5, 2024 16:58
@@ -33,7 +33,7 @@ func (c *Client) CollectionExists(ctx context.Context, collectionName string) (b
// Returns:
// - *CollectionInfo: Detailed information about the collection.
// - error: An error if the operation fails.
func (c *Client) GetCollection(ctx context.Context, collectionName string) (*CollectionInfo, error) {
func (c *Client) GetCollectionInfo(ctx context.Context, collectionName string) (*CollectionInfo, error) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To maintain parity with Rust, Java and C# clients.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc examples use this new name.

@Anush008 Anush008 merged commit a29a870 into new-client Sep 9, 2024
2 checks passed
@Anush008 Anush008 deleted the misc-fixes branch November 18, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant