Skip to content

Check if server's and client's versions are compatible #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

tellet-q
Copy link
Contributor

@tellet-q tellet-q commented Dec 19, 2024

Send request to fetch server version during client init and compare with client version.

Introduce a boolean param SkipCompatibilityCheck (false by default). If it is false -> check versions during client init and generate a warning if versions are not compatible. Compatible versions are the ones that differ by one, i.e client version 1.6.x is compatible with server versions 1.5.x and 1.7.x but not 1.4.x or 1.8.x.

@tellet-q tellet-q requested a review from Anush008 December 19, 2024 12:11
@tellet-q tellet-q requested a review from Anush008 December 20, 2024 12:51
@tellet-q tellet-q requested a review from Anush008 January 2, 2025 08:32
Copy link
Member

@Anush008 Anush008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@tellet-q tellet-q merged commit 8ed317f into master Jan 2, 2025
2 checks passed
@tellet-q tellet-q deleted the check-version-on-init branch January 2, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants