-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend write consistency factor text, reapply on client vs lower factor #1013
Open
timvisee
wants to merge
1
commit into
master
Choose a base branch
from
distributed-write-factor-lower-value
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -951,8 +951,11 @@ Qdrant provides a few options to control consistency guarantees: | |||||
|
||||||
### Write consistency factor | ||||||
|
||||||
The `write_consistency_factor` represents the number of replicas that must acknowledge a write operation before responding to the client. It is set to one by default. | ||||||
It can be configured at the collection's creation time. | ||||||
The `write_consistency_factor` represents the number of replicas that must acknowledge a write operation before responding to the client. It is set to 1 by default. | ||||||
It can be configured at the collection's creation or when updating the | ||||||
collection parameters. | ||||||
|
||||||
This value can range from 1 to the number of replicas you have for each shard. | ||||||
|
||||||
```http | ||||||
PUT /collections/{collection_name} | ||||||
|
@@ -1068,7 +1071,14 @@ await client.CreateCollectionAsync( | |||||
); | ||||||
``` | ||||||
|
||||||
Write operations will fail if the number of active replicas is less than the `write_consistency_factor`. | ||||||
Write operations will fail if the number of active replicas is less than the | ||||||
`write_consistency_factor`. In this case, the client is expected to send the | ||||||
operation again to ensure a consistent state is reached. | ||||||
|
||||||
Setting the `write_consistency_factor` to a lower value may allow accepting | ||||||
writes even if there are unresponsive nodes. Unresponsive nodes are marked as | ||||||
dead and will automatically be recovered again once available to ensure data | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
consistency. | ||||||
|
||||||
### Read consistency | ||||||
|
||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a write is accepted by one node, and that node restarts before it can propagate the write, will the write be lost?