Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate: mark async gRPC properties as deprecated in QdrantRemote #740

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

hh-space-invader
Copy link
Contributor

@hh-space-invader hh-space-invader commented Aug 15, 2024

  • Deprecated multiple async gRPC methods in favor of AsyncQdrantClient and QdrantClient.
  • Added deprecation warnings for each method.

refs: #592

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you installed pre-commit with pip3 install pre-commit and set up hooks with pre-commit install?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@hh-space-invader hh-space-invader requested a review from joein August 15, 2024 09:41
Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 3630263
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/66c256948f66110008271c0d
😎 Deploy Preview https://deploy-preview-740--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- Added deprecation warnings to async gRPC properties: async_grpc_collections, async_grpc_points, async_grpc_snapshots, and async_grpc_root

refs: #592
@hh-space-invader hh-space-invader force-pushed the TSK-592-deprecate-async-grpc branch from 8e2bb78 to 563b754 Compare August 15, 2024 12:54
@hh-space-invader hh-space-invader changed the title feat: deprecate async gRPC methods in QdrantClient and AsyncQdrantClient deprecate: mark async gRPC properties as deprecated in QdrantRemote Aug 15, 2024
@hh-space-invader hh-space-invader force-pushed the TSK-592-deprecate-async-grpc branch from 73367d2 to 3630263 Compare August 18, 2024 20:16
@joein joein merged commit 75b572c into dev Aug 18, 2024
19 of 24 checks passed
@hh-space-invader hh-space-invader deleted the TSK-592-deprecate-async-grpc branch August 21, 2024 15:49
joein pushed a commit that referenced this pull request Aug 26, 2024
…740)

* deprecate: mark async gRPC properties as deprecated in QdrantRemote

- Added deprecation warnings to async gRPC properties: async_grpc_collections, async_grpc_points, async_grpc_snapshots, and async_grpc_root

refs: #592

* deprecate: Added deprication for async_grpc in QdrantClient and QdrantRemote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants