Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServieMonitor should use with higher precedence the readOnlyApiKey #219

Closed
vitali-ipquants opened this issue Aug 12, 2024 · 1 comment · Fixed by #221
Closed

ServieMonitor should use with higher precedence the readOnlyApiKey #219

vitali-ipquants opened this issue Aug 12, 2024 · 1 comment · Fixed by #221
Assignees
@arthurk

Comments

@vitali-ipquants
Copy link

Hello Qdrant team,

If in the values.yaml are defined both apiKey and readOnlyApiKey
it will be better if the ServiceMonitor refers to the read-only key.
The Prometheus will be able to collect metrics with the read-only key,
so there's no need to pass it the more powerful key.

Thank you
arthurk added a commit that referenced this issue Aug 13, 2024
@arthurk
ServiceMonitor: Prefer read-only api-key
29a8e64 
When both `apiKey` and `readOnlyApiKey` are `true`, prefer the
read-only key as it is sufficient for scraping the metrics.

Fixes #219
@arthurk arthurk mentioned this issue Aug 13, 2024
Merged
@arthurk
Copy link
Contributor

arthurk commented Aug 13, 2024

Good catch! I've create a PR for it here #221

@arthurk arthurk self-assigned this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurk arthurk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ServiceMonitor: Prefer read-only api-key qdrant/qdrant-helm
2 participants
@arthurk @vitali-ipquants