Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow preventing test hooks from being rendered (again) #246

Open
SlowSnowFox opened this issue Sep 23, 2024 · 1 comment
Open

allow preventing test hooks from being rendered (again) #246

SlowSnowFox opened this issue Sep 23, 2024 · 1 comment

Comments

@SlowSnowFox
Copy link

Problem: We are using GCP Cloud Deploy to deploy the chart as a dependency to a GKE cluster. Cloud Deploy calls skaffold render, which, in our case, uses Helm to render the manifest. The rendered manifest then gets applied, including the test-db-interaction deployment. Although the test runs successfully and is marked as completed/successful, Cloud Deploy still marks the release as failed since the test pod is not marked as ready.

Potential Suggested Solution: Introduce a conditional render around the test deployment.

Why did I create a new issue? This is essentially the same request as described in issue #77 . That issue was marked as resolved because the test passed, and the deployment tool no longer flagged the release as failed. However, the underlying problem of preventing the test deployment from being rendered still persists.

I'm happy to create a PR for the suggested solution myself—just wanted to confirm that this mechanism would be an acceptable approach before proceeding.

@SlowSnowFox SlowSnowFox changed the title allow test hooks to be turned off (again) allow preventing test hooks from being rendered (again) Sep 23, 2024
@SlowSnowFox
Copy link
Author

In case anyone is interested in our temporary fix for google cloud deploy:

  1. skipBuildDeps in Skaffold
  2. unpack the qdrant helm chart
  3. delete the tests dir
  4. pack
  5. continue the deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant