Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Test Hook to be turned off #77

Closed
Noahhaines171 opened this issue Sep 18, 2023 · 2 comments · Fixed by #79
Closed

Allow Test Hook to be turned off #77

Noahhaines171 opened this issue Sep 18, 2023 · 2 comments · Fixed by #79
Assignees
Labels
bug Something isn't working

Comments

@Noahhaines171
Copy link

When running a helm install from behind an Enterprise Proxy and Firewall, the Test hook continually fails due to firewall blocking the python 3.11 download being done in the test script.

I would like to be able to toggle off the Test Hook to stop the test pod from being spun up at all, as it is always in 'Error' state after a deploy, requiring manual intervention to delete and remove.

When I don't remove the failed pod and attempt to helm install again, I get this error:

The Pod "qdrant-sandbox-test-db-interaction" is invalid: spec: Forbidden: pod updates may not change fields other than `spec.containers[*].image`, `spec.initContainers[*].image`, `spec.activeDeadlineSeconds`, `spec.tolerations` (only additions to existing tolerations) or `spec.terminationGracePeriodSeconds` (allow it to be set to 1 if it was previously negative)

Test-DB-Interaction Container Startup Error
Error:

+ zypper install -y python311-dbm
Refreshing service 'container-suseconnect-zypp'.
Retrieving repository 'SLE_BCI' metadata [.error]
Repository 'SLE_BCI' is invalid.
[SLE_BCI|https://updates.suse.com/SUSE/Products/SLE-BCI/15-SP5/x86_64/product/] Valid metadata not found at specified URL
History:
 - [|] Error trying to read from 'https://updates.suse.com/SUSE/Products/SLE-BCI/15-SP5/x86_64/product/'
 - Download (curl) error for 'https://updates.suse.com/SUSE/Products/SLE-BCI/15-SP5/x86_64/product/content':
   Error code: Curl error 35
Warning: Skipping repository 'SLE_BCI' because of the above error.
Loading repository data...
   Error message: Recv failure: Connection reset by peer

Please check if the URIs defined for this repository are pointing to a valid repository.
Some of the repositories have not been refreshed because of an error.
Reading installed packages...
Package 'python311-dbm' not found.
@bashofmann
Copy link
Collaborator

How and exactly with which command(s) and flags are you installing the chart? Normally, the test should only be deployed and run when executing helm test.
Nonetheless, I'll see that these will also work without an internet connection.

@Noahhaines171
Copy link
Author

Noahhaines171 commented Sep 18, 2023

How and exactly with which command(s) and flags are you installing the chart? Normally, the test should only be deployed and run when executing helm test. Nonetheless, I'll see that these will also work without an internet connection.

I started looking into that after creating this, we use Harness to deploy, and i believe it is automatically running the test hook on a rolling deploy. So not entirely something this chart is doing, but I do appreciate the small enhancement for the tests working without a download

EDIT: Yes, it seems that when Harness does a Helm deploy, it's expanding all files under the templates directory, and applying all of them. It finds the test-db-interaction.yaml and applies that along with the other template files

bashofmann added a commit that referenced this issue Sep 20, 2023
This also improves the integration test runtime and reliability by not installing a fresh cluster for every test but upgrading it with the new config.

Fixes #77
@bashofmann bashofmann self-assigned this Sep 20, 2023
@bashofmann bashofmann added the bug Something isn't working label Sep 20, 2023
bashofmann added a commit that referenced this issue Sep 29, 2023
* Fix probes when Qdrant is served over TLS

This also improves the integration test runtime and reliability by not installing a fresh cluster for every test but upgrading it with the new config.

Fixes #77

* Deactivate liveness and startup probes by default

Since these probes restart the pod on failure, they can disrupt the health of the Qdrant cluster unnecessarily and cause more problems then actually help. Having a readinessProbe is usually enough.

* Fix tests

* Try to fix connection issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants