Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Propagate signals to qdrant by changing command/args #90

Closed
wants to merge 1 commit into from

Conversation

mac-chaffee
Copy link
Contributor

Currently, the helm chart runs /bin/sh as PID 1 which does not catch signals or send them to child processes. As a result, when you delete a qdrant pod right now, it will take the full terminationGracePeriodSeconds and then get SIGKILLed.

NOTE FOR THE CHANGELOG:

This release includes a breaking change to the args value. Users who were overriding the default args with their own shell commands will now need to also set command: ['/bin/sh', '-c']. We recommend that you ensure signals are still being propagated to qdrant if you override args or command to ensure qdrant can shut down gracefully.

It is technically possible to make this a non-breaking change (use the old command if custom args are supplied), but I think it's unlikely users' custom args are capable of respecting signals with /bin/sh as PID 1.

@mac-chaffee
Copy link
Contributor Author

Apparently just changing /bin/sh to /bin/bash + using exec is enough? Anyone know if it's true that bash and sh have different exec/signal handling? If so, we can make this a non-breaking change by just using bash+exec.

@mac-chaffee
Copy link
Contributor Author

Superseded by #91

@mac-chaffee mac-chaffee closed this Oct 9, 2023
@mac-chaffee mac-chaffee deleted the fix/mac-chaffee/propagate-signals branch October 9, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant