BREAKING: Propagate signals to qdrant by changing command/args #90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the helm chart runs
/bin/sh
as PID 1 which does not catch signals or send them to child processes. As a result, when you delete a qdrant pod right now, it will take the fullterminationGracePeriodSeconds
and then get SIGKILLed.NOTE FOR THE CHANGELOG:
It is technically possible to make this a non-breaking change (use the old
command
if customargs
are supplied), but I think it's unlikely users' customargs
are capable of respecting signals with/bin/sh
as PID 1.