Fix snapshot restoration and add integration test #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mac-chaffee
force-pushed
the
fix/mac-chaffee/test-snapshots
branch
from
93981b3 to
e601537
Compare
bashofmann
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that #93 wasn't needed because we do actually want the
exec. I thought--snapshotmade the qdrant command exit or something.While testing, I also found that we need to supply the
--urlflag, otherwise the pod may crash with raft errors.After restoring the snapshot, there is still a strange warning message:
Failed to apply collection meta operation: Collection test_collection already exists!. This appears harmless since the data does get restored, but strange nonetheless.