Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt to run tests and lint #9 #15

Merged
merged 17 commits into from
Jan 21, 2022
Merged

First attempt to run tests and lint #9 #15

merged 17 commits into from
Jan 21, 2022

Conversation

monatis
Copy link
Contributor

@monatis monatis commented Jan 21, 2022

  • Test it in all supported OSs and Python versions.
  • Run black, and auto-commit changes if necessary.

@monatis
Copy link
Contributor Author

monatis commented Jan 21, 2022

Apparently it's failing because we have a dependency on private quaterion-models repo. Any suggestions? @generall @joein

@monatis
Copy link
Contributor Author

monatis commented Jan 21, 2022

Wow it's an issue since 2019 python-poetry/poetry#835

@generall
Copy link
Member

let's publish on pypi first

@monatis
Copy link
Contributor Author

monatis commented Jan 21, 2022

Now it can run tests, but tests fail in a strange way due to a regression in setuptools. I downgraded it to 59.5.0 according to this link, but still no luck. Tests run and pass successfully on local though.

@monatis monatis merged commit ed9a664 into master Jan 21, 2022
@generall generall deleted the add-workflow branch June 10, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants