increase limit && change reading order to favor XMP #1814
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description / Motivation and Context
This pull request introduces several changes to improve the handling of EXIF metadata, update the frontend component, and add new test data for long descriptions and titles. The most important changes include modifications to EXIF data reading functions, updates to the frontend's detail view sidebar, and the addition of new test data and corresponding test cases.
EXIF Data Handling Improvements:
starsky/starsky.foundation.readmeta/ReadMetaHelpers/ReadMetaExif.cs
: Updated theGetObjectName
andGetCaptionAbstract
methods to prioritize XMP data over IPTC data and ensure non-nullable return types.Frontend Component Update:
starsky/starsky/clientapp/src/components/organisms/detail-view-sidebar/detail-view-sidebar.tsx
: Increased themaxlength
attribute of theFormControl
component from 1024 to 5000 to allow longer descriptions.New Test Data and Test Cases:
starsky/starskytest/FakeCreateAn/CreateAnImageLongDescriptionTitle/CreateAnImageLongDescriptionTitle.cs
: Added a new class to handle long description and title test data.starsky/starskytest/FakeCreateAn/CreateAnImageLongDescriptionTitle/CreateAnImageLongDescriptionTitle.json
: Added JSON file containing long description and title test data.starsky/starskytest/FakeCreateAn/CreateAnImageLongDescriptionTitle/CreateAnImageLongDescriptionTitleExampleDataModel.cs
: Added a new data model class for long description and title test data.starsky/starskytest/starsky.foundation.readmeta/Services/ReadMeta_ExifReadTest.cs
: Added a new test case to validate reading EXIF data from a file with long description and title.starsky/starskytest/starskytest.csproj
: Updated the project file to include new test data files.Related Issue
How Has This Been Tested
Types of changes
Checklist