Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not using cache in keystore #1894

Closed
kamilsa opened this issue Dec 6, 2023 · 0 comments · Fixed by #2017
Closed

Fix not using cache in keystore #1894

kamilsa opened this issue Dec 6, 2023 · 0 comments · Fixed by #2017
Assignees
@Harrm
Labels
bug Something isn't working Technical debt
Milestone
Polkadot treasury...

Comments

@kamilsa
Copy link
Contributor

kamilsa commented Dec 6, 2023 •
edited
Loading

It is observed that KAGOME opens the same keystore files without using the cache here: https://github.com/soramitsu/kagome/blob/e55bef81468827f9ca383504bb5ba3a93a60225c/core/crypto/crypto_store/crypto_store_impl.hpp#L107

This leads to redundant disk reads.

This behaviour should be fixed.

Way to reproduce:

  • Put breakpoint in the line above
  • Run kagome --validator --chain localchain.json --base-path base_path --port 30363 --rpc-port 9933 from examples/first_kagome_chain
@kamilsa kamilsa added the bug Something isn't working label Dec 6, 2023
@kamilsa kamilsa added this to the Polkadot treasury milestone 2 milestone Dec 6, 2023
@Harrm Harrm mentioned this issue Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Harrm Harrm

Labels
bug Something isn't working Technical debt
Projects
None yet
Milestone
Polkadot treasury milestone 2
Development

Successfully merging a pull request may close this issue.

Refactor key store qdrvm/kagome
2 participants
@kamilsa @Harrm