Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor key store #2017

Merged
merged 35 commits into from
Apr 1, 2024
Merged

Refactor key store #2017

merged 35 commits into from
Apr 1, 2024

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Mar 22, 2024 •
edited
Loading

Referenced issues

resolves #1894

Description of the Change

  • Refactor key store to reduce code duplication
  • Scan the key directory at the node startup, avoid re-scanning it later.

Possible Drawbacks

  • Cannot add keys to a running node by simply putting them in the key directory.

@Harrm
Working on safe memory heap integration
d8940c7
@Harrm
Safe memory storage
cceeb73
@Harrm
Comment
5fc4177
@Harrm
Comment
5890611
@Harrm
Remove free function for cleanup
c3fde9e
@Harrm
Make seeds protected too
a51b29b
@Harrm
add logging
915f966
@Harrm
Fix common.cpp
717154b
@Harrm
Merge branch 'master' into feature/safe-memory
dae1767
@Harrm
Minor fix
2f3d7d1
@Harrm
Merge remote-tracking branch 'origin/feature/safe-memory' into featur…
e4db62c 
…e/safe-memory
@Harrm
Fixed some tests
d85e5f9
@Harrm
Fix bip39 seed initialization
e0668a1
@Harrm
Fixes from review
3e8c623
@Harrm
Merge branch 'master' of github.com:qdrvm/kagome into feature/safe-me…
d68fec4 
…mory
@Harrm
Refactor key store in process
8903254
@Harrm
Refactor key store
7f1130b
@Harrm
Working on safe memory heap integration
59f107d
@Harrm
Safe memory storage
7887552
@Harrm
Comment
58867ba
@Harrm
Comment
4e4456d
@Harrm
Remove free function for cleanup
bf4c1d2
@Harrm
Make seeds protected too
639e09f
@Harrm
Fixed some tests
0b654db
@Harrm
Refactor key store in process
6592d78
@Harrm
Refactor key store
1d8d79f
@Harrm
Merge with master
a5dd091
@Harrm
Merge branch 'feature/key-file-cache' of github.com:qdrvm/kagome into…
60cb78f 
… feature/key-file-cache
@Harrm
Minor fixes
00f0f9a
@Harrm
Merge branch 'feature/key-file-cache' of github.com:qdrvm/kagome into…
d839ed5 
… feature/key-file-cache
@Harrm Harrm marked this pull request as ready for review March 27, 2024 13:39
igor-egorov
igor-egorov approved these changes Apr 1, 2024
View reviewed changes
core/api/service/author/requests/has_key.hpp Outdated Show resolved Hide resolved
@Harrm @igor-egorov
Update core/api/service/author/requests/has_key.hpp
e6bb66c 
Co-authored-by: Igor Egorov <igor@qdrvm.io>
@Harrm Harrm enabled auto-merge (squash) April 1, 2024 08:32
@Harrm Harrm merged commit bd278d7 into master Apr 1, 2024
9 of 10 checks passed
@Harrm Harrm deleted the feature/key-file-cache branch April 1, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iceseer iceseer iceseer approved these changes

@igor-egorov igor-egorov igor-egorov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix not using cache in keystore
3 participants
@Harrm @igor-egorov @iceseer