Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix parachains-pvf zombietest #2203

Closed
kamilsa opened this issue Sep 2, 2024 · 1 comment
Closed

[Bug]: Fix parachains-pvf zombietest #2203

kamilsa opened this issue Sep 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kamilsa
Copy link
Contributor

kamilsa commented Sep 2, 2024

Bug Summary

Error occurs when 0001-parachains-pvf.toml is executed

Bug Description

We see that finalization is stuck on block 18 when first zombienet test is executed.

Some suspicious logs

  • alice.log, polkadot-sdk: could not decode ErasureChunk::proof
...
2024-09-02 04:59:56.047 DEBUG tokio-runtime-worker parachain::availability-recovery: Recovery strategy `Full recovery from backers` did not conclude. Trying the next one. candidate_hash=0xb59d60ff3bda5efb7fa75b7f2d13ffce06b0001edfaca51ead422864be800870 traceID=241407425176886742580951072952559075278
2024-09-02 04:59:56.047 DEBUG tokio-runtime-worker parachain::availability-recovery: Starting `Fetch chunks` strategy candidate_hash=0xb59d60ff3bda5efb7fa75b7f2d13ffce06b0001edfaca51ead422864be800870 traceID=241407425176886742580951072952559075278
2024-09-02 04:59:56.047 DEBUG tokio-runtime-worker parachain::availability-recovery: Requesting availability chunks for a candidate common_params.candidate_hash=0xb59d60ff3bda5efb7fa75b7f2d13ffce06b0001edfaca51ead422864be800870 desired_requests_count=2 error_count=0 total_received=0 threshold=3 already_requesting_count=0
2024-09-02 04:59:56.058 DEBUG tokio-runtime-worker parachain::approval-voting: Ready to issue approval vote candidate_hash=0xc70e20abeba8ec54f120a9249c8697dbf62c6504e74d1071a16a97fcb419a977 block_hash=0xe93724cebb9e6f9702ea36c7c5bbe725dae0c7c5f2339be30f8a6fa9ad1cb512 validator_index=1 traceID=264589725975274045978415208369106622427
2024-09-02 04:59:56.059 DEBUG tokio-runtime-worker parachain::approval-distribution: Distributing our approval vote on candidate (block=0xe937…b512, index=Bitfield(BitVec<u8, bitvec::order::Lsb0> { addr: 0x7f70a962ad78, head: 000, bits: 3, capacity: 8 } [0, 0, 1], PhantomData<u32>))
2024-09-02 04:59:56.059 DEBUG tokio-runtime-worker parachain::approval-distribution: Importing locally a new approval
2024-09-02 04:59:56.101 DEBUG tokio-runtime-worker parachain::availability-recovery: Chunk fetching response was invalid candidate_hash=0xb59d60ff3bda5efb7fa75b7f2d13ffce06b0001edfaca51ead422864be800870 err=InvalidResponse(Error { cause: Some(Error { cause: Some(Error { cause: None, desc: "Merkle proof depth exceeds maximum trie depth" }), desc: "Could not decode `ErasureChunk::proof`" }), desc: "Could not decode `ChunkFetchingResponse::Chunk.0`" }) authority_id=Public(1254f7017f0b8347ce7ab14f96d818802e7e9e0c0d1b7c9acb3c726b080e7a03 (1R36uL1M...)) validator_index=ValidatorIndex(3) traceID=241407425176886742580951072952559075278
2024-09-02 04:59:56.101 DEBUG tokio-runtime-worker parachain::availability-recovery: Requesting availability chunks for a candidate common_params.candidate_hash=0xb59d60ff3bda5efb7fa75b7f2d13ffce06b0001edfaca51ead422864be800870 desired_requests_count=1 error_count=1 total_received=2 threshold=3 already_requesting_count=0
2024-09-02 04:59:56.103 DEBUG tokio-runtime-worker parachain::availability-recovery: Can conclude availability recovery strategy validators_len=4 candidate_hash=0xb59d60ff3bda5efb7fa75b7f2d13ffce06b0001edfaca51ead422864be800870 received_chunks_count=3 requested_chunks_count=0 threshold=3 traceID=241407425176886742580951072952559075278
...
  • alice.log, polkadot-sdk: could not determine peer_id for validator
...
2024-09-02 05:00:06.136 DEBUG tokio-runtime-worker parachain::validator-discovery: New ConnectToValidators resolved request peer_set=Validation num_peers=7 removed=0
2024-09-02 05:00:06.140 DEBUG tokio-runtime-worker parachain::network-bridge-rx: Gossip topology has changed action="NewGossipTopology" session=2 local_index=Some(ValidatorIndex(3))
2024-09-02 05:00:06.141 DEBUG tokio-runtime-worker parachain::network-bridge-rx: Could not determine peer_id for validator, let the team know in 
https://github.com/paritytech/polkadot-sdk/issues/2138 validator_index=ValidatorIndex(3)
2024-09-02 05:00:06.141 DEBUG tokio-runtime-worker parachain::collator-protocol: Assigned to a parachain relay_parent=0x47faabd9ab5b46494bdc801d9b781a63d9544806170f5c05729c9ed4ed51cdd4 para_id=Id(2003)
2024-09-02 05:00:06.141 DEBUG tokio-runtime-worker parachain::bitfield-distribution: New gossip topology received session_index=2 newly_added_peers=1
...

Steps to Reproduce

cd zombienet/polkadot/functional
zombienet test -p native 0001-parachains-pvf.zndsl

Effects of the Bug


	 Error:  
		 Timeout(400), "getting desired metric value 30 within 400 secs".

┌──────────────────────────────┬────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ 9/2/2024, 5:07:18 AM         │ ❌ alice: reports substrate_block_height***status="finalized"*** is at least 30 within 400 seconds (4… │
└──────────────────────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────┘

Expected Behavior

Zombienet should pass

System Information

KAGOME version: v0.9.5
Polkadot-SDK version v1.15.0

Additional Context

Possibly related to #2092

logs-test-polkadot-functional-0001-parachains-pvf (10).zip

@kamilsa kamilsa added the bug Something isn't working label Sep 2, 2024
@kamilsa kamilsa added this to the Polkadot treasury milestone 3 milestone Sep 2, 2024
@kamilsa
Copy link
Contributor Author

kamilsa commented Oct 3, 2024

Fixed in #2219

@kamilsa kamilsa closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant