Fix upper bound in cursor and remove in topper batch #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
- Coverage 27.84% 27.81% -0.03%
==========================================
Files 553 553
Lines 19454 19473 +19
Branches 10069 10085 +16
==========================================
Hits 5417 5417
- Misses 9211 9215 +4
- Partials 4826 4841 +15
Continue to review full report at Codecov.
|
sanblch
approved these changes
Apr 22, 2022
| @@ -25,7 +25,9 @@ namespace kagome::authorship { | |||
| outcome::result<std::unique_ptr<BlockBuilder>> BlockBuilderFactoryImpl::make( | |||
| const kagome::primitives::BlockInfo &parent, | |||
| primitives::Digest inherent_digest) const { | |||
| #ifndef BOOST_ASSERT_IS_VOID | |||
There was a problem hiding this comment.
It is defined when BOOST_ASSERT is compiled to noop.
| @@ -212,7 +207,7 @@ namespace kagome::host_api { | |||
| if (limit_opt) { | |||
| SL_TRACE_VOID_FUNC_CALL(logger_, prefix, limit_opt.value()); | |||
| } else { | |||
| SL_TRACE_VOID_FUNC_CALL(logger_, prefix, std::string_view{"none"}); | |||
| SL_TRACE_VOID_FUNC_CALL(logger_, prefix, std::string_view {"none"}); | |||
There was a problem hiding this comment.
the file missing autoformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
related to #942
Description of the Change
Benefits
It works.
Possible Drawbacks
No funny debugging anymore.
Usage Examples or Tests
Provided in the code.