Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of runtime API for calculate state root #1183

Merged
merged 8 commits into from
Apr 29, 2022
Merged

Conversation

xDimon
Copy link
Member

@xDimon xDimon commented Apr 22, 2022

Signed-off-by: Dmitriy Khaustov aka xDimon khaustov.dm@gmail.com

Referenced issues

Resolves #1122

Description of the Change

Added version 2 for two host API methods (code for new way is stubbed now, as in substrate)
Added data structures for new types of trie nodes

Benefits

Ability to continue syncing till stubbed way won't be implemented actually

Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
feature: ext_trie_blake2_256_ordered_root_version_2

Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon requested review from kamilsa and Harrm April 22, 2022 09:48
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1183 (80a63e1) into master (778a051) will decrease coverage by 0.08%.
The diff coverage is 19.54%.

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
- Coverage   27.84%   27.76%   -0.09%     
==========================================
  Files         553      553              
  Lines       19473    19617     +144     
  Branches    10085    10119      +34     
==========================================
+ Hits         5422     5446      +24     
- Misses       9205     9317     +112     
- Partials     4846     4854       +8     
Impacted Files Coverage Δ
core/consensus/babe/types/babe_block_header.hpp 90.90% <ø> (ø)
core/host_api/host_api.hpp 100.00% <ø> (ø)
core/host_api/impl/host_api_impl.cpp 15.27% <0.00%> (-0.37%) ⬇️
core/host_api/impl/host_api_impl.hpp 100.00% <ø> (ø)
core/primitives/authority.hpp 91.66% <ø> (ø)
core/primitives/digest.hpp 33.33% <0.00%> (-2.78%) ⬇️
core/primitives/transaction.hpp 20.00% <ø> (ø)
...re/runtime/binaryen/runtime_external_interface.cpp 30.09% <0.00%> (-0.63%) ⬇️
...re/runtime/wavm/intrinsics/intrinsic_functions.cpp 0.00% <0.00%> (ø)
core/storage/trie/impl/trie_storage_impl.cpp 40.74% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778a051...80a63e1. Read the comment docs.

@xDimon xDimon enabled auto-merge (squash) April 22, 2022 22:42
core/primitives/digest.hpp Show resolved Hide resolved
@xDimon xDimon requested a review from GaroRobe April 29, 2022 09:19
@xDimon xDimon merged commit f6ad19a into master Apr 29, 2022
@xDimon xDimon deleted the fix/state_root branch April 29, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New storage root function
3 participants