Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of open files by database #1319

Merged
merged 4 commits into from
Aug 24, 2022
Merged

Conversation

GaroRobe
Copy link
Contributor

Fixes #1314

Referenced issues

Limit number of open files by database #1314

Description of the Change

We set rocksdb setting for maximum opened files to half of system's soft-limit for file descriptors.

Benefits

We should stop running out of file descriptors.

Possible Drawbacks

Usage Examples or Tests

Alternate Designs

@GaroRobe GaroRobe requested review from turuslan, xDimon and Harrm and removed request for xDimon August 16, 2022 19:10
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #1319 (9439c08) into master (04cc63f) will increase coverage by 0.01%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   25.66%   25.67%   +0.01%     
==========================================
  Files         598      598              
  Lines       21566    21575       +9     
  Branches    11200    11205       +5     
==========================================
+ Hits         5534     5540       +6     
+ Misses      10919    10915       -4     
- Partials     5113     5120       +7     
Impacted Files Coverage Δ
core/injector/application_injector.cpp 34.44% <0.00%> (-0.24%) ⬇️
core/common/fd_limit.cpp 10.25% <40.00%> (+10.25%) ⬆️
core/api/transport/impl/ws/ws_listener_impl.cpp 43.05% <0.00%> (+2.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GaroRobe GaroRobe self-assigned this Aug 16, 2022
core/common/fd_limit.hpp Outdated Show resolved Hide resolved
@GaroRobe GaroRobe requested a review from turuslan August 17, 2022 07:51
@GaroRobe GaroRobe enabled auto-merge (squash) August 17, 2022 08:19
@GaroRobe GaroRobe merged commit 34c4542 into master Aug 24, 2022
@GaroRobe GaroRobe deleted the feature/rocksdb-files-limit branch August 24, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit number of open files by database
4 participants