Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inserting block before base #1325

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Aug 22, 2022

Signed-off-by: kamilsa kamilsa16@gmail.com

Referenced issues

Related to #1218

Description of the Change

We observed that we could crash when inserting block into vote graph when it is less than base block of this graph

Benefits

Fix failure behavior

Possible Drawbacks

None

Usage Examples or Tests

Test is added

Signed-off-by: kamilsa <kamilsa16@gmail.com>
Signed-off-by: kamilsa <kamilsa16@gmail.com>
@kamilsa kamilsa requested review from Harrm, turuslan and ortyomka and removed request for Harrm August 22, 2022 13:29
@kamilsa kamilsa enabled auto-merge (squash) August 22, 2022 13:30
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1325 (282c593) into master (b7c0cdc) will decrease coverage by 0.02%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
- Coverage   25.73%   25.70%   -0.03%     
==========================================
  Files         594      595       +1     
  Lines       21514    21521       +7     
  Branches    11168    11169       +1     
==========================================
- Hits         5536     5532       -4     
- Misses      10861    10878      +17     
+ Partials     5117     5111       -6     
Impacted Files Coverage Δ
.../consensus/grandpa/vote_graph/vote_graph_error.cpp 20.00% <20.00%> (ø)
...e/consensus/grandpa/vote_graph/vote_graph_impl.cpp 46.77% <100.00%> (+0.43%) ⬆️
core/metrics/impl/session_impl.cpp 37.50% <0.00%> (-8.34%) ⬇️
core/api/transport/impl/ws/ws_listener_impl.cpp 40.27% <0.00%> (-2.78%) ⬇️
core/metrics/impl/prometheus/handler_impl.cpp 26.53% <0.00%> (-2.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kamilsa kamilsa merged commit ba0b00a into master Aug 23, 2022
@kamilsa kamilsa deleted the fix/inserting_block_before_base branch August 23, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants