encodeSs58 fix for id >= 64 #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: elestrias <rus8-2002@mail.ru>
xDimon
requested changes
Oct 20, 2022
Co-authored-by: Dmitriy Khaustov <khaustov.dm@gmail.com>
kamilsa
approved these changes
Jan 9, 2023
xDimon
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: elestrias rus8-2002@mail.ru
Referenced issues
Ss58codec protocol is working in different way after 64 index of network(f.e 69 - SORA network)
Description of the Change
the ss58 encode function is extended, new case was added according to protocol https://docs.substrate.io/fundamentals/accounts-addresses-keys/
Benefits
new codec will be able to work with all substrate addresses
Possible Drawbacks
Usage Examples or Tests
ss58encode(69, accountId, HasherImpl());
Alternate Designs