sign converted statement #1355
Merged
sign converted statement #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1355 +/- ##
==========================================
- Coverage 24.17% 24.17% -0.01%
==========================================
Files 627 627
Lines 23440 23446 +6
Branches 12258 12258
==========================================
Hits 5667 5667
- Misses 12497 12503 +6
Partials 5276 5276
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xDimon
reviewed
Sep 30, 2022
turuslan
force-pushed
the
parachain/sign-statement
branch
from
5bb5b35
to
50d52c9
Compare
xDimon
approved these changes
Oct 6, 2022
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
turuslan
force-pushed
the
parachain/sign-statement
branch
from
50d52c9
to
0c2bd44
Compare
iceseer
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
ValidatorSignerconvertsStatementbefore signing.candidateHashwill be reused in "parachain_processor.cpp".Benefits
Statement signed correctly
Possible Drawbacks