Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authority manager initialization during fast sync #1359

Merged
merged 4 commits into from
Oct 7, 2022

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Oct 3, 2022

Referenced issues

Description of the Change

Authority manager tried to access the runtime storage without checking if it's possible.

Benefits

Kagome works properly when restarting fast sync.

Possible Drawbacks

None expected.

@Harrm Harrm requested review from kamilsa and xDimon October 3, 2022 18:38
@Harrm Harrm self-assigned this Oct 3, 2022
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1359 (d9c6b86) into master (0957e2a) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1359   +/-   ##
=======================================
  Coverage   24.17%   24.17%           
=======================================
  Files         627      627           
  Lines       23446    23449    +3     
  Branches    12258    12260    +2     
=======================================
+ Hits         5667     5669    +2     
- Misses      12503    12504    +1     
  Partials     5276     5276           
Impacted Files Coverage Δ
...onsensus/authority/impl/authority_manager_impl.cpp 21.59% <0.00%> (-0.15%) ⬇️
core/api/transport/impl/ws/ws_listener_impl.cpp 43.05% <0.00%> (+2.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Harrm Harrm merged commit ddf27db into master Oct 7, 2022
@Harrm Harrm deleted the fix/authority-manager-fast-sync-initialization branch October 7, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants