Pass peer_id by value #1366
Merged
Pass peer_id by value #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1366 +/- ##
=======================================
Coverage 24.16% 24.17%
=======================================
Files 627 627
Lines 23449 23449
Branches 12260 12260
=======================================
+ Hits 5667 5669 +2
+ Misses 12507 12504 -3
- Partials 5275 5276 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xDimon
approved these changes
Oct 11, 2022
igor-egorov
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
After #1360 was done we thought that problem of falling because of nullptr was resolved, but it wasn't. This fix should done it for sure
Benefits
No fallings
Possible Drawbacks
None