Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fast sync on Kusama #1367

Merged
merged 91 commits into from
Nov 3, 2022
Merged

Fix fast sync on Kusama #1367

merged 91 commits into from
Nov 3, 2022

Conversation

Harrm
Copy link
Contributor

@Harrm Harrm commented Oct 11, 2022 •
edited
Loading

Referenced issues

Part of #1164

Description of the Change

  • Unknown authorities are ignored
  • When we are unable to finalize a block with justification, we just move forward
  • Some minor changes in authority manager

Benefits

Kusama can be fast sync'ed.

Possible Drawbacks

None expected.

Alexander Krutikov and others added 30 commits August 4, 2022 14:41
add --sync program option (#1164)
5fb66f8
implement block appender for fast sync (#1164)
6b67c60
apply sync state and start validating (#1164)
82464b9 
apply sync state and start validating (#1164)

move syncState call into babe (#1164)
recursive fast sync call (#1164)
2eb5893 
recursive fast sync call (#1164)
add calculation of authorities from origin (#1164)
ebf7fef
fastsync working on rococo (#1164)
f677f08
implement child state request (#1164)
b2c7628
implement state response (#1164)
6c535b2
fastsync working on polkadot (#1164)
6589f95
clang-14 fixes
0214220
updates for PR
760fef3
@xDimon
git: Merge branch 'master' into feature/fast-sync-update
c6bb6e4
@xDimon
fix: processing of epoch digests during fast syncing
bff1ee2 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
git: Merge branch 'master' into feature/fast-sync-update
e911f09
@xDimon
fix: tests
1e3db6d 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
Merge branch 'master' into feature/fast-sync-update
f0e62b2
@iceseer @xDimon
Build fix for external blob (#1306)
91e2f4f 
Signed-off-by: iceseer <iceseer@gmail.com>
@xDimon
Feature: change logging level over RPC in real time #1305
bf1d618 
* feature: change logging level over RPC

Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
feature: change logging level over RPC
9516996 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
feature: accelerate hasDirectChain check for case of finalized chain
9481e76 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
refactor: optimize prepareFromGenesis of AuthorityManager
70b5877 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
refactor: preload a bit more blocks while fast syncing
db4d41c 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
fix: logging some outcome error
af65850 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
feature: smart processing of duplicating blocks during fast sync
d02c0bf 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
git: Merge branch 'master' into feature/fast-sync-update
bd15e37
@xDimon
feature: indicate average speed of appending while fast syncing
8f2c6d7 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
feature: down rating of peer at disconnection
908f4ae 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
tune: preload more headers while fast syncing
c7e40b4 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
clean: remove commented piece of code
bef9c70 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon
fix: test
a984c52 
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
xDimon
xDimon reviewed Oct 18, 2022
View reviewed changes
core/consensus/authority/impl/authority_manager_impl.cpp Outdated Show resolved Hide resolved
core/consensus/authority/impl/authority_manager_impl.cpp Outdated Show resolved Hide resolved
core/consensus/authority/impl/schedule_node.hpp Outdated Show resolved Hide resolved
core/consensus/babe/types/slot.hpp Outdated Show resolved Hide resolved
core/consensus/grandpa/CMakeLists.txt Outdated Show resolved Hide resolved
core/consensus/grandpa/impl/vote_crypto_provider_impl.cpp Outdated Show resolved Hide resolved
core/network/impl/stream_engine.hpp Outdated Show resolved Hide resolved
core/primitives/babe_configuration.hpp Outdated Show resolved Hide resolved
core/runtime/common/runtime_environment_factory.cpp Outdated Show resolved Hide resolved
core/runtime/common/runtime_environment_factory.cpp Outdated Show resolved Hide resolved
xDimon
xDimon approved these changes Oct 21, 2022
View reviewed changes
core/network/impl/stream_engine.hpp Show resolved Hide resolved
@xDimon xDimon enabled auto-merge (squash) November 3, 2022 08:03
@xDimon xDimon force-pushed the feature/kusama-fast-sync-fix branch from 84f7095 to 715f0c9 Compare November 3, 2022 08:17
@xDimon xDimon disabled auto-merge November 3, 2022 08:17
@xDimon xDimon enabled auto-merge (squash) November 3, 2022 08:18
@xDimon xDimon merged commit e47d231 into master Nov 3, 2022
@xDimon xDimon deleted the feature/kusama-fast-sync-fix branch November 3, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turuslan turuslan turuslan approved these changes

@xDimon xDimon xDimon approved these changes

@kamilsa kamilsa Awaiting requested review from kamilsa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Harrm @xDimon @kamilsa @turuslan @iceseer