Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: optional using of backtrace instruments #1382

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

xDimon
Copy link
Member

@xDimon xDimon commented Oct 28, 2022

Signed-off-by: Dmitriy Khaustov aka xDimon khaustov.dm@gmail.com

Referenced issues

None

Description of the Change

Backward library is made optional

Benefits

It provides ability to switch of this instrument

Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@xDimon xDimon marked this pull request as ready for review October 28, 2022 14:51
@xDimon xDimon enabled auto-merge (squash) October 28, 2022 15:08
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1382 (ea2f7a0) into master (10b8811) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ea2f7a0 differs from pull request most recent head f68371e. Consider uploading reports for the commit f68371e to get more accurate results

@@            Coverage Diff             @@
##           master    #1382      +/-   ##
==========================================
- Coverage   24.60%   24.58%   -0.03%     
==========================================
  Files         629      629              
  Lines       23613    23613              
  Branches    12288    12288              
==========================================
- Hits         5811     5806       -5     
- Misses      12530    12540      +10     
+ Partials     5272     5267       -5     
Impacted Files Coverage Δ
core/utils/kagome_db_editor.cpp 0.00% <ø> (ø)
node/main.cpp 0.00% <ø> (ø)
core/metrics/impl/session_impl.cpp 37.50% <0.00%> (-8.34%) ⬇️
core/metrics/impl/prometheus/handler_impl.cpp 26.53% <0.00%> (-2.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xDimon xDimon merged commit dbee05c into master Oct 28, 2022
@xDimon xDimon deleted the feature/make_backward_optional branch October 28, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants