Fix trie serialize #1388
Merged
Fix trie serialize #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1388 +/- ##
==========================================
- Coverage 24.87% 24.84% -0.03%
==========================================
Files 629 629
Lines 23808 23794 -14
Branches 12328 12314 -14
==========================================
- Hits 5922 5912 -10
- Misses 12598 12609 +11
+ Partials 5288 5273 -15
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
xDimon
approved these changes
Nov 7, 2022
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Harrm
reviewed
Nov 7, 2022
| @@ -118,7 +88,13 @@ namespace kagome::storage::trie { | |||
| if (db_key.empty() or db_key == getEmptyRootHash()) { | |||
| return nullptr; | |||
| } | |||
| OUTCOME_TRY(enc, backend_->load(db_key)); | |||
| Buffer enc; | |||
| if (codec_->isMerkleHash(db_key)) { | |||
There was a problem hiding this comment.
Here it's better to comment that a db key is actually the merkle value of the node, or better wrap Buffer in some MerkleValue type to ensure this contract on type level.
There was a problem hiding this comment.
It's not clear from this comment why it is this way. I think it's better clarify it, or it may become a source of confusion.
Harrm
approved these changes
Nov 7, 2022
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
merkleValuewhich are not hashed.Benefits
TopperTrieBatchImpl::clearPrefixPossible Drawbacks