Fix state root #1413
Merged
Fix state root #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harrm
approved these changes
Nov 17, 2022
kamilsa
approved these changes
Nov 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #1413 +/- ##
=======================================
Coverage 24.45% 24.45%
=======================================
Files 638 638
Lines 24084 24085 +1
Branches 12492 12492
=======================================
+ Hits 5889 5890 +1
Misses 12938 12938
Partials 5257 5257
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
TrieStorageProviderImplreused byRuntimeInstancesPooldidn't clearpersistent_batch_, soforceCommitreturned wrong roothttps://github.com/soramitsu/kagome/blob/ff91cec93517a5a270d4a13ed35b57bce0b9ca90/core/runtime/common/trie_storage_provider_impl.cpp#L102-L105
Benefits
Possible Drawbacks