Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage spaces support #1446

Merged
merged 19 commits into from
Jan 26, 2023
Merged

Add storage spaces support #1446

merged 19 commits into from
Jan 26, 2023

Conversation

igor-egorov
Copy link
Contributor

@igor-egorov igor-egorov commented Dec 14, 2022

Signed-off-by: Igor Egorov igor@soramitsu.co.jp

Referenced issues

Resolves to #1312

Description of the Change

Use spaced storage engine

Benefits

Ease of operating over the storage

Igor Egorov added 5 commits January 16, 2023 00:19
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Igor Egorov added 2 commits January 20, 2023 04:22
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Igor Egorov added 3 commits January 25, 2023 12:41
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Igor Egorov added 3 commits January 25, 2023 15:37
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
@igor-egorov igor-egorov marked this pull request as ready for review January 25, 2023 13:05
@igor-egorov igor-egorov enabled auto-merge (squash) January 25, 2023 13:19
core/blockchain/impl/block_storage_impl.cpp Outdated Show resolved Hide resolved
core/storage/rocksdb/rocksdb.cpp Show resolved Hide resolved
core/blockchain/impl/storage_util.hpp Outdated Show resolved Hide resolved
Igor Egorov added 3 commits January 25, 2023 17:37
Kagome db editor is not operable at the moment.
It will be fixed as part of aggressive pruning task

Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
core/blockchain/impl/block_storage_impl.cpp Outdated Show resolved Hide resolved
block_number,
block_data.hash,
Buffer{encoded_block_data}));
OUTCOME_TRY(putToSpace(*storage_,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right. We are putting block data into a separate space. However we can also be putting header into a 'headers' space. Therefore, if block data contains header we may store the same block header twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fields are kept for binary consistency and are not to be used

Igor Egorov added 2 commits January 26, 2023 10:16
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
@igor-egorov igor-egorov merged commit d5dcd58 into master Jan 26, 2023
@igor-egorov igor-egorov deleted the spaced-storage branch January 26, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants