Git hooks to checking of code formatting #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
igor-egorov
approved these changes
Jan 31, 2023
Signed-off-by: Dmitriy Khaustov aka xDimon <khaustov.dm@gmail.com>
turuslan
reviewed
Feb 1, 2023
| if [ $CLANG_FORMAT_ENABLED ]; then | ||
| for FILE in $(git diff-index --name-only ${BASE} | grep -e "\\.[ch]pp$"); do | ||
| TMPFILE=$(mktemp /tmp/kagome_precommit_hook.XXXXXX) | ||
| clang-format "$FILE" >"$TMPFILE" |
There was a problem hiding this comment.
May avoid temp file
expected=$(clang-format "$file")
expected_hash=$(echo "$expected" | shasum)
actual_hash=$(cat "$file" | shasum)
if [ "$actual_hash" != "$expected_hash" ]; then
echo "format: fixing"
tmp="$file.tmp"
echo "$expected" > "$tmp"
mv "$tmp" "$file"
else
echo "format: ok"
fi
turuslan
reviewed
Feb 1, 2023
| # check c++ files' format with clang-format | ||
| CXX_RES=0 | ||
| if [ $CLANG_FORMAT_ENABLED ]; then | ||
| for FILE in $(git diff-index --name-only ${BASE} | grep -e "\\.[ch]pp$"); do |
Harrm
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
No special
Description of the Change
Added external git-hooks and shell-script for their activation
pre-commit git-hook with checkings of code formatting (C++ and Cmake files)
Recommended clang-format version promoted to version 15
Activated 'InsertBraces' clang-format rule
Benefits
Uniformly formatted code without unintentionally missed non-formatted ones