Feature/missing host apis #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 26, 2023 12:28
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Harrm
reviewed
Mar 27, 2023
| * @param child_storage_key a pointer-size indicating the child storage key | ||
| * @param limit is an optional number of records to remove | ||
| * @param prefix a pointer-size indicating the prefix | ||
| * @return pointer to number of records removed |
There was a problem hiding this comment.
I see an enum in Rust, is it encoded to just the number of records?
| prefix_buffer); | ||
|
|
||
| if (!result) { | ||
| logger_->error( |
There was a problem hiding this comment.
Should we not abort the execution of this runtime call with an exception?
added 2 commits
March 28, 2023 14:12
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Harrm
approved these changes
Mar 28, 2023
kamilsa
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Resolves #1541
Description of the Change
Implement missing host apis.
ext_default_child_storage_clear_prefix_version_2: func (i64, i64, i64)->i64ext_default_child_storage_root_version_2: func (i64, i32)->i64ext_default_child_storage_storage_kill_version_3: func (i64, i64)->i64Possible Drawbacks
clear_prefix_V1andstorage_kill_V1could be rewritten to use V2 and V3 and reduce code duplication.