Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topper cursor #1546

Merged
merged 5 commits into from
Apr 7, 2023
Merged

Topper cursor #1546

merged 5 commits into from
Apr 7, 2023

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • TopperTrieCursor (ext_storage_next_key_version_1 and ext_default_child_storage_next_key_version_1) applies pending transactions

Benefits

  • Sora syncs

Possible Drawbacks

  • TopperTrieCursor is currently used only by wasm, so unused methods seekLast and prev were removed for simplicity

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@kamilsa kamilsa requested a review from xDimon April 4, 2023 09:28
@turuslan turuslan requested a review from Harrm April 4, 2023 09:58
Harrm
Harrm previously approved these changes Apr 5, 2023
Copy link
Contributor

@Harrm Harrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's spelled 'choice' though.

xDimon
xDimon previously approved these changes Apr 6, 2023
@turuslan turuslan dismissed stale reviews from xDimon and Harrm via 83f7cb0 April 6, 2023 12:05
@turuslan turuslan enabled auto-merge (squash) April 6, 2023 12:06
@turuslan turuslan merged commit 572070e into master Apr 7, 2023
@turuslan turuslan deleted the fix/topper-cursor branch April 7, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants