Make block benchmark #1569
Merged
Make block benchmark #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agome into feature/block-exec-benchmark
turuslan
requested changes
Apr 26, 2023
Comment on lines
+27
to
+30
| # https://docs.hunter.sh/en/latest/packages/pkg/benchmark.html | ||
| hunter_add_package(benchmark) | ||
| find_package(benchmark CONFIG REQUIRED) | ||
|
|
There was a problem hiding this comment.
Not used
Suggested change
| # https://docs.hunter.sh/en/latest/packages/pkg/benchmark.html | |
| hunter_add_package(benchmark) | |
| find_package(benchmark CONFIG REQUIRED) |
There was a problem hiding this comment.
We agreed that we would need it anyway in the near future so I'd rather keep it.
There was a problem hiding this comment.
Then must update benchmark in soramitsu-hunter
Comment on lines
+744
to
+747
| if (subcommand) { | ||
| argc--; | ||
| argv++; | ||
| } |
There was a problem hiding this comment.
Should command remove first arg too?
kamilsa
approved these changes
Apr 27, 2023
| @@ -13,7 +13,7 @@ | |||
| #include <rapidjson/document.h> | |||
| #include <rapidjson/filereadstream.h> | |||
| #include <boost/algorithm/string.hpp> | |||
| #include <boost/filesystem.hpp> | |||
| #include "filesystem/common.hpp" | |||
turuslan
approved these changes
Apr 27, 2023
…ier fallback to boost::filesystem if needed
…agome into feature/block-exec-benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
resolves #1393
Description of the Change
Add new kagome command 'benchmark' and subcommand 'block'. It runs the specified range of blocks several times and prints out the execution time, comparing it to the block weight.
Benefits
Measurement of kagome performance.
Possible Drawbacks
None expected.