Fix/Tranches to approve fixup #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
This reverts commit 16f5a99.
fixup validator index check Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com>
…rove_fixup Signed-off-by: iceseer <iceseer@gmail.com> # Conflicts: # core/parachain/approval/approval_distribution.cpp
Signed-off-by: iceseer <iceseer@gmail.com>
Signed-off-by: iceseer <iceseer@gmail.com> # Conflicts: # core/parachain/approval/approval_distribution.cpp
iceseer
force-pushed
the
fix/tranches_to_approve_fixup
branch
from
a14ab83 to
c528aa6
Compare
Signed-off-by: iceseer <iceseer@gmail.com>
iceseer
force-pushed
the
fix/tranches_to_approve_fixup
branch
from
c528aa6 to
9ed82f4
Compare
turuslan
approved these changes
May 4, 2023
Signed-off-by: iceseer <iceseer@gmail.com> # Conflicts: # core/parachain/approval/approval_distribution.cpp
kamilsa
approved these changes
May 10, 2023
| std::chrono::system_clock::now().time_since_epoch()) | ||
| .count() | ||
| / kTickDurationMs; | ||
| return msNow() / kTickDurationMs; |
There was a problem hiding this comment.
Maybe instead use existing clock->nowUint64() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change